enh: Update Predibase integration to support v2 API #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Apr 10, 2024
| raise RuntimeError(f"Adapter {model_id} is not yet available") | ||
| return path | ||
| else: | ||
| # Use legacy path only since new endpoint requires both name and version number. |
There was a problem hiding this comment.
Looks like this code is identical to 54:58. Can we pull it into a function?
def fetch_legacy_url(legacy_url):
resp = requests.get(legacy_url, headers=headers)
resp.raise_for_status()
uuid, best_run_id = resp.json()["uuid"], resp.json()["bestRunID"]
return f"{uuid}/{best_run_id}/artifacts/model/model_weights/"
martindavis
reviewed
Apr 10, 2024
| return f"{uuid}/{best_run_id}/artifacts/model/model_weights/" | ||
|
|
||
| if url is not None: | ||
| try: |
There was a problem hiding this comment.
Just trying to think about this in terms of customer impact: we really only expect staging to use this for the next few days until we migrate all of LLM Models to the Adapters table and a very brief window in Prod while we migrate the data right?
martindavis
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predibase is releasing a new API for working with and retrieving adapters. This PR updates Lorax's Predibase integration to prefer the new API, falling back to the legacy endpoints to maintain backwards compatibility during the transition period.